This page last changed on Aug 04, 2009 by smaddox.

Once you have set up your Crucible server as an Eclipse task repository, you can perform a Crucible review without leaving Eclipse. The Atlassian Connector for Eclipse allows you to create and manage comments in your Eclipse code editor, as described in another topic. You can also manage your review comments in the diff view, as described below.

Can't see comments in your code editor?
If you want to work with your Crucible review in the Eclipse code editor, the review task must be active in Mylyn Eclipse. See the instructions on managing review comments.

To add review comments in a diff view,

  1. Open the Crucible review in an Eclipse review editor. Follow these instructions to open the review from your code editor, or see the complete instructions on opening a review:
    • Make sure that the Crucible review task is active in Mylyn Eclipse. To activate the Mylyn task, right-click the review in your Eclipse Mylyn task list and select 'Activate'.
    • Scroll down your code editor until you see a review comment marked by a Crucible icon in the left-hand ruler.
    • Hover over the Crucible icon to see the comment text and other details.
    • Press F2 to bring the comment into focus.
    • The review comment box becomes an inline dialogue box. Click 'Open Review' to open the review in the Eclipse review editor.
  2. Open the diff view by clicking 'Compare' next to the file you want, in the 'Review Files' section of the review editor as shown in diagram 1 below.
  3. The 'Compare' view opens, as shown in diagram 1 below. Select a code line or a block of lines in the Eclipse code editor and right-click.
  4. Select either 'Create General File Comment' or "Create Line Comment'. In diagram 1 below, we show you how to add a line comment.
  5. A popup window will ask you for the comment details. Enter the comment text, supply the other information if necessary, and 'Post' the comment.


Diagram 1: Adding review comments in a diff view

To reply to and update review comments in a diff view,

  1. Open the Crucible review in an Eclipse review editor. Follow these instructions to open the review from your code editor, or see the complete instructions on opening a review:
    • Make sure that the Crucible review task is active in Mylyn Eclipse. To activate the Mylyn task, right-click the review in your Eclipse Mylyn task list and select 'Activate'.
    • Scroll down your code editor until you see a review comment marked by a Crucible icon in the left-hand ruler.
    • Hover over the Crucible icon to see the comment text and other details.
    • Press F2 to bring the comment into focus.
    • The review comment box becomes an inline dialogue box. Click 'Open Review' to open the review in the Eclipse review editor.
  2. Open the diff view by clicking 'Compare' next to the file you want, in the 'Review Files' section of the review editor as shown in diagram 2 below.
  3. The 'Compare' view opens, as shown in diagram 2 below. Scroll down until you see a review comment marked by a Crucible icon in the left-hand ruler.
    • Hover over the Crucible icon to see the comment text and other details.
    • Press F2 to bring the comment into focus.
    • The review comment box becomes an inline dialogue box. Now you can reply to the comment, edit it or delete it, depending on your permissions.


Diagram 2: Working with review comments in a diff view

Next, take a look at creating a post-commit review.

RELATED TOPICS

Working with Crucible Reviews in Eclipse

Refer to the Crucible documentation for more information about Crucible reviews.


Adding comments in diff view (text/xml)
CrucibleAddLineComment.jpg (image/jpeg)
CrucibleAddCommentInDiff.jpg (image/jpeg)
Adding comments in diff view (application/octet-stream)
CrucibleReviewInDiff.jpg (image/jpeg)
Adding comments in diff view (application/octet-stream)
CrucibleReviewDetails_truncated.jpg (image/jpeg)
Adding comments in diff view (application/octet-stream)
Adding comments in diff view (application/octet-stream)
Adding comments in diff view (application/octet-stream)
Working in diff view (application/octet-stream)
Adding comments in diff view (application/octet-stream)
Adding comments in diff view (application/octet-stream)
Working in diff view (application/octet-stream)
Working in diff view (application/octet-stream)
Working in diff view (application/octet-stream)
Document generated by Confluence on Mar 17, 2010 21:17